- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
This is a nice UX issue. Assigning to myself to try to get this into the next release.
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Fyi, for all the people who've added updated patches above, in the future, please include interdiffs so we know easily what has changed:
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Here are crude raw diffs between the 4 patches.
- Issue was unassigned.
- Status changed to Needs work
almost 2 years ago 12:16am 11 April 2023 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
Quick review of the last patch in #15. I haven't tested.
-
+++ b/src/Form/MediaBulkUploadForm.php @@ -482,6 +483,12 @@ protected function processFile(MediaBulkConfigInterface $mediaBulkConfig, FileIn + throw new \Exception('File entity could not be created.');
Nitpick: missing space before
throw
-
+++ b/src/Form/MediaBulkUploadForm.php @@ -536,6 +543,31 @@ protected function validateFileSize(MediaTypeInterface $mediaType, FileInterface + * Media Type.
Nitpick: The media type.
-
+++ b/src/Form/MediaBulkUploadForm.php @@ -536,6 +543,31 @@ protected function validateFileSize(MediaTypeInterface $mediaType, FileInterface + * @param array $file + * File.
Fix param type:
array
=>File
Nitpick: The file.
-
- Assigned to Kristen Pol
- πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I'm going to fix this one and test it.
-
Kristen Pol β
committed e24852ff on 3.0.x authored by
ashu1629 β
Issue #3081948 by Nick Dewitte, fonant, vinaySreedhara, rhristov,...
-
Kristen Pol β
committed e24852ff on 3.0.x authored by
ashu1629 β
- Issue was unassigned.
- Status changed to Fixed
almost 2 years ago 5:58am 12 April 2023 - πΊπΈUnited States Kristen Pol Santa Cruz, CA, USA
I tested and did some tweaks to the code. I found that it is fine for dealing with the max resolution but not the min which was noted above in #15. But this may be due to:
π Image fields minimum dimension restrictions don't apply equally in D7 and D8 Fixed
so I'm going to let this slide for now. It does resize the image when it's too big which is nice.
Automatically closed - issue fixed for 2 weeks with no activity.