content_moderation_entity_bundle_field_info overrides the target bundle setting on the field definition for all bundles

Created on 29 August 2019, over 5 years ago

Updated 29 March 2023, over 1 year ago

Problem/Motivation

I’ve been searching for something else when I’ve seen content_moderation_entity_bundle_field_info(). I think that there might be a potential bug, because it does not clone the base field definition when setting the target bundle. I think that this might lead to overriding the target bundle setting for every bundle, because you’re re-using the reference to the original base field and not creating an unique object for each bundle.

Requesting the bundle fields for multiple bundles of the same entity type in a single request should demonstrate the problem.

An example for the correct implementation is \Drupal\taxonomy\Entity\Term::bundleFieldDefinitions().

Proposed resolution

Would it be possible to switch to the new FieldDefinition class - https://www.drupal.org/node/2982512 → - and pass the base field definition to \Drupal\Core\Field\FieldDefinition::createFromFieldStorageDefinition()? This way we would not need to clone the base field anymore? I guess that we’ll also need an updated or a new CR describing this. Also to ensure no similar bugs occur we might start requiring from Drupal 9 that all objects returned by hook_entity_bundle_field_info() implementations are an instance of FieldDefinition and not BaseFieldDefinition.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

🐛 Bug report

Status

Needs work

Version

10.1 ✨

Component

Content moderation →

Last updated 24 days ago

Maintained by
🇦🇺Australia @Sam152

Created by

🇩🇪Germany hchonov 🇪🇺🇩🇪🇧🇬

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

@taran2l opened merge request.
First commit to issue fork.
Comment over 1 year ago →
🇺🇦Ukraine Taran2L Lviv
hello, run into the same issue while working on 🐛 The "moderation_state" base field overrides cause install from existing config to fail Needs work . The idea is to move to bundle fields (as moderation_state is per bundle) ... and it kinda works (one failing test is due to change in the test entity ... )

But, I think the whole Bundle Fields API portion is ... not finished, and while it works from the UI, but config import/export does not work

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024