Sort menu list by menu title

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request → as a guide.

This was tagged for tests in #8 that still need to happen.

Did not review the code.

Confirmed the issue exists in manual testing. Added a test.

Fixing the code standards.

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

Failure in #17 seems legit

Fixed test failures.

Applied patch #21 in 10.x successfully and it fixes the issue. Adding screenshots for reference.

Not 100% sold on the test fix. As they use to pass before and this change shouldn't have caused those to fail. But will let the committer decide.

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

The last submitted patch, 17: 3070721-17.patch, failed testing. View results →

1. +++ b/core/modules/menu_ui/src/MenuListBuilder.php
   @@ -17,6 +17,23 @@ class MenuListBuilder extends ConfigEntityListBuilder {
   +      ->accessCheck(TRUE)
   

   I don't think config entities can have query access, so this is redundant and can be removed. phpstan should no longer warn about this too, but it was at one point.

2. +++ b/core/modules/menu_ui/tests/src/Functional/MenuListBuilderTest.php
   @@ -0,0 +1,92 @@
   +   * Tests the menus are listed alphabetically.
   +   */
   +  public function testMenusListedAlphabetically(): void {
   +    // Test alphabetical order without pager.
   

   Is there an existing test that we could add an assertion to?

Addressed #47, please review

Points in #47 appear to be addressed.

Committed 6ec16df and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.