Link "create URL aliases" results in 404 if the user doesn't have permission

Just stumbled on this issue on one of our Drupal sites and wondering if this can be progressed and committed?

The whole message

> The source path %path is likely a valid path. It is preferred to create URL aliases for existing paths rather than redirects.

May not even be correct as it is not programmatically determine if its a "valid path", using language like "likely".

I'd rather not display the message at all if the user cant access the link.

This can be done with $url->access rather than permission checks, which are not enough when custom access control is added on a route.

My preference is MR !106, though I think proper messaging should be added in the other existing catch blocks, and the use of HTML and faking messenger is also gross. Out of scope.

Unsure what to do about that. Combining multiple translatable strings together is definitely not good, because that will mess with LTR languages. Fine to just go with MR 106, just removing the message seems a bit tricky, but better than showing an inaccessible link I guess.

Berdir → closed merge request !105

Thanks. Happy with this headline-satisfying change.

The block remains less than ideal, lets tackle other changes in follow ups.

Automatically closed - issue fixed for 2 weeks with no activity.