Add access control to /filter/tips

Added a new permission "view filter tips page" for handling access to the generic /filter/tips page.

Will need a change record and IS update if this approach is signed off

The Needs Review Queue Bot → tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.

quietone → changed the visibility of the branch 3063877-add-access-control to hidden.

Rebase onto 11.x.

update.

kumudb → changed the visibility of the branch 3063877-add-access-control to active.

kumudb → changed the visibility of the branch 3063877-add-page-access-permissions to hidden.

I have raised the MR for filter/tips page access permission.
MR : https://git.drupalcode.org/project/drupal/-/merge_requests/9617/diffs

Proposed solution doesn't match what appears in the MR.

Also will need some kind of update hook to assign the new permission, without it people who correctly should have access all of a sudden won't.

New permissions will need a CR.

Also why start a new MR, the previous one 3565 is pointing to 11.x correctly

Unfortunately the MR added in #23 added an unnecessary change and caused a new failure. I've hidden that one and continued with the original 3565.

This adds fixes for some of the tests.

The new permission has been added to the authenticated role in Umami and Standard which needs to be discussed. The Filter module is not enabled in either of the profiles and that is causing test failures. It seems that Filter now needs to be installed in both profiles. And I would then only add the new permission, to the author, editor and content_editor roles.

I'm wondering if we should remove filter tips altogether, it is not really fit for purpose. Sites can add description text to text fields with formatting hints when not using a WYSIWYG editor. Would need product manager sign off and probably in a new issue, with this one postponed in case it doesn't happen?

OK. Let's no make a change here until that is decided.