The Needs Review Queue Bot → tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".
Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.
Consult the Drupal Contributor Guide → to find step-by-step guides for working with issues.
- Status changed to Needs review
about 2 years ago 12:05pm 12 April 2023 - Status changed to Needs work
about 2 years ago 4:51pm 12 April 2023 - 🇺🇸United States smustgrave
@Nikhil_110 thank you for the interest but you have been doing this for a while now. Please check the patch vs just rerolling which was intended for novice users. Can see that as a bug there is no test coverage for this so there for not ready for review.
Please do some checks before putting into review
- First commit to issue fork.
- Merge request !11602Issue #3059030: Mark node access grants as needing rebuild at the start of the rebuild process → (Closed) created by acbramley
- 🇺🇸United States smustgrave
1) Drupal\Tests\node\Kernel\NodeAccessTest::testNodeAccessRebuildNeedsRebuild Failed asserting that false is true. /builds/issue/drupal-3059030/core/modules/node/tests/src/Kernel/NodeAccessTest.php:182 FAILURES!Pretty small change, test coverage is kernel so yay there
Summary is complete and matches the solution. Comment reads well too.
- 🇬🇧United Kingdom catch
Committed/pushed to 11.x, thanks!
Doesn't cherry-pick to 11.1.x so leaving fixed against 11.x for now.
