StorageComparer WSODs on serialization

Created on 10 May 2019, over 5 years ago
Updated 25 June 2024, 6 months ago

Problem/Motivation

Coming from #3035514: On config distro update with translations: WSOD "The database connection is not serializable" β†’ .

\Drupal\Core\Config\StorageComparer breaks on serialization if it contains nondefault $sourceStorages/$targetStorages (plural).

DependencySerializationTrait cares for $sourceStorage/$targetStorage (singular) if they come from the service container, but not for $sourceStorages/$targetStorages (plural).

Proposed resolution

Do not serialize $sourceStorages/$targetStorages (plural), as they are anyway generated on the fly in ::getSourceStorage/::getTargetStorage.

Remaining tasks

* Roll a patch
* Decide on if and how this should be tested
* Roll a test
* Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

πŸ› Bug report
Status

Needs work

Version

11.0 πŸ”₯

Component
ConfigurationΒ  β†’

Last updated 2 days ago

Created by

πŸ‡©πŸ‡ͺGermany geek-merlin Freiburg, Germany

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

  • First commit to issue fork.
  • Merge request !8544Adding Kernel test β†’ (Open) created by trackleft2
  • Pipeline finished with Failed
    6 months ago
    Total: 215s
    #208160
  • Pipeline finished with Failed
    6 months ago
    Total: 177s
    #208163
  • Pipeline finished with Canceled
    6 months ago
    Total: 505s
    #208166
  • Pipeline finished with Failed
    6 months ago
    Total: 1070s
    #208170
  • Pipeline finished with Failed
    6 months ago
    Total: 659s
    #208874
  • Pipeline finished with Success
    6 months ago
    Total: 550s
    #209299
Production build 0.71.5 2024