Fix not working result limit with match limit

Created on 10 May 2019, over 5 years ago
Updated 15 September 2024, 3 months ago

Problem/Motivation

Result:

It always show 10 results (the default limit).

Probable cause:

It seems that uses EntityAutocompleteMatcher (core/lib/Drupal/Core/Entity/EntityAutocompleteMatcher.php) to search results and it uses a handwritten limit.

Steps to reproduce

  1. Set up autocomplete deluxe widget on tags field in any content type.
  2. On manage form display change the limit value.
  3. Create (or edit) a content and fill the autocomplete field.

Proposed resolution

  • Change limit with match limit
  • A hook update for that is needed too.
  • To make sure that all old configs for field form displays are updated.

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ✅ Readability
  • ✅ Accessibility
  • ✅ Performance
  • ➖ Security
  • ➖ Documentation
  • ✅ Code review by maintainers
  • ✅ Full testing and approval
  • ✅ Credit contributors
  • ✅ Review with the product owner
  • ✅ Release notes snippet
  • ✅ Release autocomplete_deluxe-2.0.4

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code (miscellaneous)

Created by

🇪🇸Spain ilaz

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.71.5 2024