- First commit to issue fork.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Waiting for branch to pass - @dieterholvoet opened merge request.
- Open on Drupal.org →Core: 10.0.7 + Environment: PHP 8.1 & MySQL 8last update
over 1 year ago Waiting for branch to pass - Status changed to Needs review
over 1 year ago 10:03am 1 August 2023 - 🇧🇪Belgium dieterholvoet Brussels
I updated the config schema and added an update hook.
-
Rajab Natshah →
committed 40df5eb8 on 2.0.x authored by
DieterHolvoet →
Issue #3053907: Fix not working result limit with match limit
-
Rajab Natshah →
committed 40df5eb8 on 2.0.x authored by
DieterHolvoet →
- 🇯🇴Jordan Rajab Natshah Jordan
Problem/Motivation
Result:
It always show 10 results (the default limit).
Probable cause:
It seems that uses
EntityAutocompleteMatcher
(core/lib/Drupal/Core/Entity/EntityAutocompleteMatcher.php
) to search results and it uses a handwritten limit.Steps to reproduce
- Set up autocomplete deluxe widget on tags field in any content type.
- On manage form display change the limit value.
- Create (or edit) a content and fill the autocomplete field.
Proposed resolution
- Change
limit
withmatch limit
- A hook update for that is needed too.
- To make sure that all old configs for field form displays are updated.
Remaining tasks
- ✅ File an issue
- ✅ Addition/Change/Update/Fix
- ➖ Testing to ensure no regression
- ➖ Automated unit testing coverage
- ➖ Automated functional testing coverage
- ➖ UX/UI designer responsibilities
- ✅ Readability
- ✅ Accessibility
- ✅ Performance
- ➖ Security
- ➖ Documentation
- ✅ Code review by maintainers
- ➖ Full testing and approval
- ✅ Credit contributors
- ➖ Review with the product owner
- ➖ Release notes snippet
- ❌ Release
API changes
- N/A
Data model changes
- N/A
Release notes snippet
- N/A
- Status changed to Fixed
4 months ago 5:20pm 9 September 2024 Automatically closed - issue fixed for 2 weeks with no activity.