- 🇺🇦Ukraine artem_sylchuk Lutsk
Also, I noticed that anyone in a thread has permission to delete the thread. That seems pretty aggressive, no?
Deleting a thread only hides messages for the thread member who "deleted" it.
The actual thread entity is deleted when all the members "deleted" it.
There were changes in #3179135: Delete Conversations as Admin → related to that - Status changed to Needs work
over 1 year ago 12:26pm 28 April 2023 - 🇺🇦Ukraine artem_sylchuk Lutsk
Looks good for me (added 2 minor comments to the MR), however the new feature should go to the 3.x branch
- last update
over 1 year ago 7 pass - last update
over 1 year ago 7 pass - last update
over 1 year ago 7 pass - Status changed to Needs review
over 1 year ago 8:31pm 2 May 2023 - 🇨🇦Canada sagesolutions
Thanks for the review @artem_sylchuk.
Please re-review!
- Status changed to Needs work
over 1 year ago 8:22am 4 May 2023 - 🇺🇦Ukraine artem_sylchuk Lutsk
Hey, there is a small note on the MR.
I'll merge it once it is resolved, however I see some issues related to this functionality.
As an admin I see the contextual delete link, however I don't see it as a regular user even I still can access the delete url directly.Also there is some inconsistency, the Thread entity doesn't use ContentEntityDeleteForm as the base class for its deletion form and it cause some difference in log messages and how the deletion forms look (but probably that's fine as threads deletion work a bit differently).
Another small issue is the lack of private message label() method. The message deletion confirmation message uses message id now and it looks not really good.
However all the above except the note in MR should be addressed as the separate issues in my opinion.
- last update
over 1 year ago 7 pass - last update
over 1 year ago 7 pass - Status changed to Needs review
over 1 year ago 8:27pm 4 May 2023 - last update
over 1 year ago 7 pass -
artem_sylchuk →
committed e994a9b2 on 3.0.x authored by
sagesolutions →
Issue #3051300 by sagesolutions, artem_sylchuk: Delete a message in the...
-
artem_sylchuk →
committed e994a9b2 on 3.0.x authored by
sagesolutions →
- Status changed to Fixed
over 1 year ago 10:50am 5 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.
- Status changed to Fixed
about 1 year ago 7:03pm 7 December 2023 - 🇫🇮Finland anaconda777
Hi,
I can see the delete message link only as admin?
Is this the intention to show private message delete button only in the contextual links?