Contrib.social

Follow-up for #2948828: add test coverage for Layout Builder's custom Quick Edit render pipeline once Quick Edit integration tests have been stabilized

Open on Drupal.org →
Created on 24 March 2019, over 5 years ago
Updated 2 February 2024, 11 months ago

Problem/Motivation

Quoting #2948828-145: Layout Builder's Field Blocks do not work with Quick Edit → :

Ok this patch goes patch removing testLayoutBuilderRenderPipelineForQuickEdit() because seems impossible and beyond the scope of the issue to make random test failure proof QuickEdit test for Layout builder. In HEAD the \Drupal\Tests\quickedit\FunctionalJavascript\QuickEditIntegrationTest which is QuickEdit's own tests fail randomly already. So that will need to be fixed in #3037436: [random test failure] Make QuickEditIntegrationTest more robust and fail proof →

[…]
I talked with @xjm, @tim.plunkett and @Wim Leers and we agreed that this best we can for test coverage given the existing random failures in QuickEdit tests.

Proposed resolution

#2948828: Layout Builder's Field Blocks do not work with Quick Edit → should land shortly, and then after #3037436: [random test failure] Make QuickEditIntegrationTest more robust and fail proof → is fixed we'll be able to bring back \Drupal\Tests\quickedit\FunctionalJavascript\QuickEditIntegrationTest::testLayoutBuilderRenderPipelineForQuickEdit.

Remaining tasks

  1. Wait for #2948828: Layout Builder's Field Blocks do not work with Quick Edit → -> [PP-1] then
  2. Wait for #3037436: [random test failure] Make QuickEditIntegrationTest more robust and fail proof → -> not postponed on anything anymore then
  3. Re-review the test coverage on this issue, perhaps adjusting based on changed in #3037436: [random test failure] Make QuickEditIntegrationTest more robust and fail proof →
  4. Commit.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

None.

📌 Task
Status

Active

Version

11.0 🔥

Component
Layout builder  →

Last updated 2 days ago

Created by

🇧🇪Belgium wim leers Ghent 🇧🇪🇪🇺

Live updates comments and jobs are added and updated live.
  • Blocks-Layouts

    Blocks and Layouts Initiative. See the #2811175 Add layouts to Drupal issue.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 11 months ago →
    🇳🇿New Zealand danielveza Brisbane, AU

    I'm going through and triaging LB issues. It would be good to get an update/some thoughts on this one. I'm leaning towards marking it as outdated based on #11

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024