Display the PayPal logo next to the PayPal option in Checkout

I agree this is still an issue, as other payment methods, like Stripe show payment method buttons.

The commerce_stripe module solves it by letting the user select the logo(s) to show. Would that also be an option here?

@jsacksick if you could give us a direction where to go here, we'd be happy to create a MR. Thanks! :)

if you could give us a direction where to go here

, I'm not really sure, the logic to actually replace the option by a logo would probably remain the same.

I think we should simply make this configurable (either a setting to toggle the option replacement by a logo, or even a logo style setting, with a 'none' option.

Thanks @jsacksick we'll plan that and I think we should then do it similar (or the same) how commerce stripe does it:

@anybody the setting you describe for stripe is for the checkout display only, not the payment method selection pane.

Stripe always shows the logos on the payment method selection pane (even if they would have access to the plugin's settings there).

So I'd vote for a simple checkbox:
TRUE => Show logo instead of string
FALSE => Show string

Mhm I'd still vote to cover all potential cases, like in 11. It's not untypical to show both, the label and the Logo and furthermore a string-based setting is extensible in the future in contrast to a checkbox.

Done, please review!

Ok talked about this with @anybody internally. We feel like this would cover further use cases.

Ok, this should be it. Here are some screenshots:

We also thought about an additional optional description field, which could be displayed right under the payment method. @jsacksick should we implement this here as well, or create a follow-up issue?

Left a few comments. Also regarding the smart payment buttons style label change. I'm not against the change, but keep in mind the smart payment buttons are also displayed on the cart page. So maybe we should say in cart / checkout?

Also why not adding a field to customize the description as well.

Ok, that should be it! Please review!

I'm testing the patch manually now and I'm wondering... Why do we need an extra label field when we already have a display label?
There is a name, a display name, and now a label under "Payment method selection display".

@jsacksick yea I think, I wanted to explicitly override the label on the selection screen only. But that's not necessary, agreed. I removed it.

Ok one last thing... And I think we should be good:

Customize the display of the payment method selection page.

Should we say the following instead?

"Customize the display of the PayPal payment option at checkout."?

or "Control how the PayPal payment method is displayed during checkout."

Went with "Customize the display of the PayPal payment option at checkout.". If you're fine with that, I can merge the MR and tag a new release.

Automatically closed - issue fixed for 2 weeks with no activity.