"Edit summary" button for the text with summary widget has unthemable markup

Created on 14 March 2019, over 5 years ago
Updated 4 July 2023, 12 months ago

In the text.es6.js file there is the following code:

          // Set up the edit/hide summary link.
          const $link = $(
            `<span class="field-edit-link"> (<button type="button" class="link link-edit-summary">${Drupal.t(
              'Hide summary',
            )}</button>)</span>`,
          );

That is outputting some markup without using Drupal.theme().

That markup should be wrapped with a theme function so themes can override it.

✨ Feature request
Status

Needs work

Version

11.0 🔥

Component
Text  →

Last updated 9 days ago

Created by

🇪🇸Spain rodrigoaguilera Barcelona

Live updates comments and jobs are added and updated live.
  • Needs issue summary update

    Issue summaries save everyone time if they are kept up-to-date. See Update issue summary task instructions.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024