Contrib.social

Entity Reference fields shown as "Select List" and using an Entity Reference Views as source may clear original value on edit depending on user permissions

Open on Drupal.org →
Created on 7 March 2019, about 6 years ago
Updated 7 November 2024, 5 months ago

Problem/Motivation

When using an Entity Reference field with a Form Display Select List and configured to use an Entity Reference Source Views, the original field value may be overridden when editing the node. This happens in some cases based on user permissions.
If the current user role/permissions don't allow access to the Entity Reference Source Views, the Select List is rendered empty. When the entity is saved - the field is saved as is, i.e. empty.

It may not be a problem if the field is required or if any custom Validation was applied to the field before submission (depending validations of course).

How to reproduce

  1. Bootstrap a clear Drupal 8 & quick-start it using Umami
    composer create-project drupal-composer/drupal-project:8.x-dev drupal_core_3038288 --stability dev --no-interaction

    Next, execute the following command:

    php web/core/scripts/drupal quick-start demo_umami

    This will start a built-in PHP webserver, install Drupal’s Umami profile to a SQLite database, and open your web browser to login to the new Drupal site.
  2. Add a new Views (admin/structure/views/add) Entity Reference Source for the Tags taxonomy vocabulary.

    Fill-up the basic informations (name, machine_name, ...), then save and edit it.
  3. Change the permission of this view to use the Access:Role | Administrator and finalize your Views by saving it.
  4. Edit the Tags field of Article (admin/structure/types/manage/article/fields/node.article.field_tags) to use our new Entity Reference Source as source .
  5. Update the Form Display of Tags (admin/structure/types/manage/article/form-display) field a Select Listdisplay.
  6. Login as any Editor and access to the translation of node/7/edit. The field Tags is now empty.

    Originally, this entity - Skip the spirits with delicious mocktails - was tagged as Alcohol free article.

  7. Saving the entity will remove the previous Alcohol free value.

Proposed resolution

On Entity Reference field, when the source is a View page Entity Reference Source, we should check the source permission.
If the current user can't see the source, then we should disable the field & maybe add a description to the user why he can't update this field.

Remaining tasks

  • Write a patch
  • Write tests

User interface changes

TBD

API changes

TBD

🐛 Bug report
Status

Postponed: needs info

Version

11.0 🔥

Component

field system

Created by

🇨🇭Switzerland wengerk Lausanne

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment 5 months ago →
    🇳🇿New Zealand quietone

    On Drupal 11.x, Umami, install I am not able to follow the steps to reproduce this because there is no option for "Entity Reference Source" when creating a view. That was removed in #2429191: Deprecate entity_reference.module and move its functionality to core → in 2015 several years before this issue was created. That leaves me confused.

    This needs confirmation that this is still a problem and, if so, complete steps to reproduce the issue → starting from "Install Drupal core".

    I am setting the status to Postponed (maintainer needs more info). If we don't receive additional information to help with the issue, it may be closed after three months.

    Thanks!

  • Status changed to Closed: outdated 25 days ago
  • Comment 25 days ago →
    🇺🇸United States smustgrave

    Since there hasn't been a follow up going to close out for now. If still an issue in D11 please reopen.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024