Convert ImageEffectsTest & ToolkitTest into Kernel tests

Created on 25 February 2019, over 5 years ago
Updated 11 September 2023, 9 months ago

Problem/Motivation

Part of the 🌱 [META] Remove all usages of drupal_static() & drupal_static_reset() Active effort for usages of drupal_static() and drupal_static_reset() in \Drupal\Tests\image\Functional\ImageEffectsTest tests.

  • Most of the methods from ImageEffectsTest are not doing any HTTP request. The exception is ::testEffectFormValidationErrors() but its scope could be tested with Kernel rather than Functional test.
  • No method from ToolkitTest is doing HTTP requests

.

Proposed resolution

  • Convert ImageEffectsTest into a Kernel test.
  • Convert ToolkitTest into a Kernel test.
  • Deprecate \Drupal\FunctionalTests\Image\ToolkitTestBase.
  • Add a new trait \Drupal\Tests\Traits\Core\ToolkitTestTrait to provide reusable code.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

Release notes snippet

N/A

πŸ“Œ Task
Status

Fixed

Version

9.1

Component
Image moduleΒ  β†’

Last updated about 4 hours ago

Created by

πŸ‡·πŸ‡΄Romania claudiu.cristea Arad πŸ‡·πŸ‡΄

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024