Support searching by email address on order add / reassign forms

just a reroll.

Just picking up on a small change to this, Drupal 10.1

`$query = DefaultSelection::buildEntityQuery($match, $match_operator);`

$match adds a condition of name

so you end up with:

where
...
name CONTAINS "aaa"
and
(name CONTAINS "aaa" or email CONTAINS "aaa")

NULL'ing the match works in my use case.

@jsacksick I don't think we want to wait on a core improvement to the selection entity. If it really is this simple to resolve, let's do it. That said, while the patch does work for me to search by partial match on email address in addition to username, it doesn't show the email address in the autocomplete suggestions.

I'm going to move this to "Needs work", and we need some way to ensure the autocomplete suggestions include the searched parameters, like:

Username <email.address@example.com> (UID)

vmarchuk → made their first commit to this issue’s fork.

@rszrama

MR is ready for review https://git.drupalcode.org/project/commerce/-/merge_requests/221.
See how it looks on the screenshot:

Looks great to me! And just as a note, we can't easily include the uid in the autocomplete suggestion, because it would be duplicated on selection. I think it's fine for the suggestions to just be John Doe <john.doe@example.com>. Tested as working on the order create and reassign forms.

One thing I don't really understand from the code is how the following works?
$query = DefaultSelection::buildEntityQuery($match, $match_operator);

The buildEntityQuery()is non static so how does this not crash?

Ok so although it may look like a static call, it isn't, and the tests are passing... Merging this! Thanks Vitaliy.

Automatically closed - issue fixed for 2 weeks with no activity.