(Follow up to #2919596: Add support for free trials → )
It would be great if we could have free trials that don't require the user to enter a payment method when starting their free trial. Potential use cases:
- Programmatically starting the user on a free trial when they register.
- Not wanting to require/store payment details before the user decides they want to pay for a subscription.
Currently, starting a subscription requires a payment method. From \Drupal\commerce_recurring\EventSubscriber\OrderSubscriber::onPlace:
$payment_method = $order->get('payment_method')->entity;
if (empty($payment_method)) {
return;
}
(I ran into this first because \Drupal\commerce_payment\Plugin\Commerce\CheckoutPane\PaymentInformation::buildPaneForm doesn't show the payment form when an order's total is 0, which is the case when purchasing a subscription that allows free trials.)
As far as I can tell, creating a subscription entity doesn't require a payment method. Does this mean we could do something like (very roughly):
- Not return when we don't have a payment method in \Drupal\commerce_recurring\EventSubscriber\OrderSubscriber::onPlace.
- If we do have a payment method (when requiring one for a free trial) , fill it in when creating the subscription.
- If we don't have a payment method, leave it empty when creating the subscription, and then add the payment method (update the subscription entity) when the user decides to pay for their subscription.
Fixed
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Just to comment on #14 and #15 - looking at the patch you are still able to collect the payment method, even for a free trial, but with this patch in place if you decide not to collect it, it is still possible to create a Subscription. Previously such an initial order would fail silently and no subscription would be created.