pinned and not-pinned classes not assigned to header element

Created on 23 January 2019, over 6 years ago
Updated 21 November 2024, 5 months ago

After installation of the module itself and its dependencies, enabling the module in the admin, only the headroom, headroom--top, and headroom--bottom classes are appended to header tag's class list.

The headroom.js library also requires the headroom-pinned and headroom--unpinned classes to work.

Is there a reason for this?

I should add that I am viewing the page as user/0, i.e. without the admin toolbar.

πŸ› Bug report
Status

Fixed

Component

Code

Created by

πŸ‡ΊπŸ‡ΈUnited States jasloe

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States hongpong Philadelphia

    I have updated the front page of the module to address the confusing issue of the tolerance variable. I think we can mark this fixed at this point since it was not an issue with the code of the module itself. Thanks all.

  • πŸ‡«πŸ‡·France dqd London | N.Y.C | Paris | Hamburg | Berlin

    @hongpong: Thanks for your awesome work and your calm responsiveness here +1 And sorry @kevinquillen: I forgot that old threat actually and I missed your last reply. I am not sure after which amount of night shifts of me we both did collide...

    Sorry, I am not going to respond or engage in harassment or personal attacks / snark, which is how that comes off. There is no reason for that.

    There was nothing of me intended like that in any way. If it read like this, then please accept my apologizes. I actually very rarely lost my composure in life. I don't know what triggered me at the time or how I maybe interpreted your comments. I do not even think that it was meant like it reads now. It is too long ago. And not my native tongue. I assume it was at this time when I realized a certain down going contrib activity rate on Drupal.org and a diminishing quality assurance motivation of maintainers in general at the time of that core lifecycle. It was rather in a "fight for Drupal" type-of energy as a whole, and nothing against your comments at all.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024