Contrib.social

Toolbar does not work with "nolink" links

Open on Drupal.org →
Created on 22 January 2019, over 5 years ago
Updated 4 October 2023, about 1 year ago

Problem/Motivation

When adding a menu item without a link to a menu displayed in the toolbar, the padding differs from that of menu items that do have a link.

Steps to reproduce

  1. Setup a fresh install of Drupal 9.5.x
  2. Add a link to the Administration menu: /admin/structure/menu/manage/admin/add
  3. Make sure this menu item does not have an actual link: use <nolink> in the path field
  4. Position the link so that it is visible at the level of Content, Structure, Appearance, etc.
  5. See that the no-link menu item is not aligned properly and has different styling that the other links
  6. Additional check: decrease the size of your browser window until it forces the white bar into a vertical column
  7. The non-link item is not aligned properly in the vertical tray either.

Proposed resolution

Apply the same padding for non-link menu items as menu item links.

Remaining tasks

  • Create issue
  • Propose solution
  • Write a patch
  • Test and review patch
  • Commit!

User interface changes

The solution should neatly align submenu links and non-links, both when displayed horizontally and in the vertical toolbar tray.

🐛 Bug report
Status

Needs work

Version

9.5

Component
Toolbar  →

Last updated about 11 hours ago

  • Maintained by
  • 🇫🇷France @nod_
Created by

🇩🇪Germany tstoeckler Essen, Germany

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024