- š³šæNew Zealand Gold 20 minutes in the future
I'm in the process of updating a site to Drupal 10 and it was applying this patch. However, when applying it to 1.2.0 via cweagans/composer-patches it no longer applies. I'm at the end of my day so won't be working on this right now, but I have a client paying me to do this work. I'll see about getting a refactored patch tomorrow and also see if I can work in the form_id check.
- Assigned to chandreshgiri gauswami
- Status changed to Active
about 1 year ago 2:46pm 19 October 2023 - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 12:30pm 20 October 2023 - š®š³India chandreshgiri gauswami
I have checked for both forms user registration and password reset. It is not redirecting user from registration form. If anyone faces the issues, please post comment so I can regenerate and do needful.
- Status changed to Needs work
about 1 year ago 8:13am 23 October 2023 - š§šŖBelgium tim-diels Belgium š§šŖ
@Chandreshgiri Gauswami, can you provide an interdiff?
- Status changed to Needs review
about 1 year ago 3:03pm 25 October 2023 - š®š³India chandreshgiri gauswami
@tim-diels please find this diff file.
- š§šŖBelgium tim-diels Belgium š§šŖ
@Chandreshgiri Gauswami, Iām not getting why you make noise in this issue. The module is already Drupal 10 compatible. So hiding you patch and interdiff as this is just wrong.
- š®š³India chandreshgiri gauswami
I have re-rolled the patch according to latest module version. The interdiff file is generated in comparison of 3025297-set-login-redirect-4.patch and 3025297-11.patch patches.
3025297-set-login-redirect-4.patch was not getting applied as describe in #9.
- š§šŖBelgium tim-diels Belgium š§šŖ
Added patch from #4 as MR to run the pipelines.
- š§šŖBelgium tim-diels Belgium š§šŖ
PHPStan reports 2 errors:
------ ---------------------------------------------------------------------- Line src/Form/SettingsForm.php ------ ---------------------------------------------------------------------- 26 \Drupal calls should be avoided in classes, use dependency injection instead 69 \Drupal calls should be avoided in classes, use dependency injection instead ------ ---------------------------------------------------------------------- [ERROR] Found 2 errors
- š§šŖBelgium tim-diels Belgium š§šŖ
PHPStan issues for Drupal 10.x are fixed. For next major Drupal 11.x there is still an issue but can be handled at later point?
Still needs to be tested to see if everything works correctly. -
tim-diels ā
committed 0898c9a0 on 8.x-1.x
Issue #3025297 by tim-diels, nbaosullivan, colorfield, leksat, phily,...
-
tim-diels ā
committed 0898c9a0 on 8.x-1.x
- š§šŖBelgium tim-diels Belgium š§šŖ
Thanks for all the work. I've tested this and it works as expected. Committed.