Allow user to define login redirection path

Created on 11 January 2019, about 6 years ago
Updated 16 October 2023, over 1 year ago

Login redirect is hard-coded, we should allow users with correct permission to define this in an admin settings form.

Thanks to all that have contributed to this immensely useful module.

āœØ Feature request
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡¬šŸ‡§United Kingdom nbaosullivan

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • šŸ‡³šŸ‡æNew Zealand Gold 20 minutes in the future

    I'm in the process of updating a site to Drupal 10 and it was applying this patch. However, when applying it to 1.2.0 via cweagans/composer-patches it no longer applies. I'm at the end of my day so won't be working on this right now, but I have a client paying me to do this work. I'll see about getting a refactored patch tomorrow and also see if I can work in the form_id check.

  • Status changed to Active over 1 year ago
  • šŸ‡®šŸ‡³India chandreshgiri gauswami

    I will work on it.

  • Issue was unassigned.
  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡³India chandreshgiri gauswami

    Providing patch

  • šŸ‡®šŸ‡³India chandreshgiri gauswami

    I have checked for both forms user registration and password reset. It is not redirecting user from registration form. If anyone faces the issues, please post comment so I can regenerate and do needful.

  • Status changed to Needs work over 1 year ago
  • šŸ‡§šŸ‡ŖBelgium tim-diels Belgium šŸ‡§šŸ‡Ŗ

    @Chandreshgiri Gauswami, can you provide an interdiff?

  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡³India chandreshgiri gauswami

    @tim-diels please find this diff file.

  • šŸ‡§šŸ‡ŖBelgium tim-diels Belgium šŸ‡§šŸ‡Ŗ

    @Chandreshgiri Gauswami, Iā€™m not getting why you make noise in this issue. The module is already Drupal 10 compatible. So hiding you patch and interdiff as this is just wrong.

  • šŸ‡®šŸ‡³India chandreshgiri gauswami

    I have re-rolled the patch according to latest module version. The interdiff file is generated in comparison of 3025297-set-login-redirect-4.patch and 3025297-11.patch patches.

    3025297-set-login-redirect-4.patch was not getting applied as describe in #9.

  • Merge request !11Adding patch from #4 ā†’ (Merged) created by tim-diels
  • šŸ‡§šŸ‡ŖBelgium tim-diels Belgium šŸ‡§šŸ‡Ŗ

    Added patch from #4 as MR to run the pipelines.

  • šŸ‡§šŸ‡ŖBelgium tim-diels Belgium šŸ‡§šŸ‡Ŗ

    PHPStan reports 2 errors:

     ------ ---------------------------------------------------------------------- 
      Line   src/Form/SettingsForm.php                                             
     ------ ---------------------------------------------------------------------- 
      26     \Drupal calls should be avoided in classes, use dependency injection  
             instead                                                               
      69     \Drupal calls should be avoided in classes, use dependency injection  
             instead                                                               
     ------ ---------------------------------------------------------------------- 
     [ERROR] Found 2 errors 
    
  • šŸ‡§šŸ‡ŖBelgium tim-diels Belgium šŸ‡§šŸ‡Ŗ

    PHPStan issues for Drupal 10.x are fixed. For next major Drupal 11.x there is still an issue but can be handled at later point?
    Still needs to be tested to see if everything works correctly.

  • šŸ‡§šŸ‡ŖBelgium tim-diels Belgium šŸ‡§šŸ‡Ŗ
  • Pipeline finished with Skipped
    6 months ago
    #296742
    • tim-diels ā†’ committed 0898c9a0 on 8.x-1.x
      Issue #3025297 by tim-diels, nbaosullivan, colorfield, leksat, phily,...
  • šŸ‡§šŸ‡ŖBelgium tim-diels Belgium šŸ‡§šŸ‡Ŗ

    Thanks for all the work. I've tested this and it works as expected. Committed.

  • šŸ‡§šŸ‡ŖBelgium tim-diels Belgium šŸ‡§šŸ‡Ŗ
Production build 0.71.5 2024