Book navigation block doesn't appear on unpublished book outline pages

Open on Drupal.org →

Created on 13 December 2018, over 6 years ago

Updated 4 September 2024, 7 months ago

Problem/Motivation

Users with access to view unpublished nodes cannot see the book navigation block when they're on an unpublished book page.
This is an unexpected behaviour and it is even more pronounced after #26552: Allow users with access to unpublished nodes to create unpublished books → .

Steps to reproduce

- Enable core "Book" module and set the basic configuration for the content type under /admin/structure/book/settings.
- Make sure the current user can see unpublished nodes (or at least the content types selected above).
- Create an unpublished top level book page and add few unpublished child pages.
- Place the "Book navigation" block in a visible region, selecting "Show block only on book pages" in the block settings and without further "Visibility" conditions.
- Visit any of the unpublished book pages.

Proposed resolution

Introducing a dedicated "View navigation for unpublished books" permission in order to only display the block when the user is browsing a book on unpublished nodes (which the user has already permission to see).

Remaining tasks

- None -

User interface changes

The Book navigation block will be visible on unpublished nodes if the user has been given access to "View navigation for unpublished books" permission. The block will also contain navigation links to unpublished nodes of the same book.

API changes

- None -

Data model changes

- None -

Before patch:

After patch:

🐛 Bug report

Status

Needs work

Version

2.0

Component

Last updated about 2 months ago

Maintained by
🇺🇸United States @pwolanin

Created by

🇬🇧United Kingdom dddbbb

Live updates comments and jobs are added and updated live.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Sign in to follow issues

Merge Requests

!43Book navigation block doesn't appear on unpublished book outline pages
Merged
🇺🇸United States smustgrave
updated 6 months ago

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment over 1 year ago →
🇳🇿New Zealand quietone
This extension is being deprecated, see 🌱 [Meta] Tasks to deprecate Book module Active . It will be removed from core and moved to a contrib project, 📌 [11.x] [Meta] Tasks to remove Book Active .

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

This issue may be re-opened if it can be considered critical → , If unsure, re-open the issue and ask in a comment.
Status changed to Needs work 12 months ago7:35am 24 April 2024
Comment 12 months ago →
🇳🇿New Zealand quietone
Comment 7 months ago →
🇺🇸United States smustgrave
Still needs tests.
Merge request !43Issue #3020298 by flocondetoile, elgandoz, ayushmishra206, vsujeetkumar,... → (Merged) created by smustgrave
Comment 6 months ago →
🇺🇸United States smustgrave
I don't think we need a separate permission. If a user can see unpublished content then the block on that page is fair game. Added test coverage

Comment 6 months ago →

smustgrave → committed 0c402ab5 on 2.0.x

Issue #3020298 by flocondetoile, elgandoz, ayushmishra206, vsujeetkumar...

Comment 6 months ago →
🇺🇸United States smustgrave
Comment 6 months ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024