- ๐ฎ๐ณIndia riddhi.addweb
I tried to apply patch #5 but after that, it showed me PHPCS errors.
FILE: /var/www/html/web/drupal10/web/modules/contrib/media_expire/src/Plugin/GraphQL/DataProducer/FallbackEntity.php
--------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
57 | ERROR | [x] Multi-line function declarations must have a trailing comma after the last parameter
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------FILE: /var/www/html/web/drupal10/web/modules/contrib/media_expire/src/Commands/MediaExpireCommands.php
--------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------
6 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\media_expire\MediaExpireService.
--------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------FILE: /var/www/html/web/drupal10/web/modules/contrib/media_expire/media_expire.module
----------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------------------
10 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\media\MediaInterface.
----------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------- - ๐ฎ๐ณIndia atul ghate
atul_ghate โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 2 months ago 11:22am 10 July 2024 - Status changed to RTBC
about 2 months ago 12:20pm 10 July 2024 - ๐ฎ๐ณIndia riddhi.addweb
The mentioned phpcs issue is resolved, & I have also checked and it is working as expected. I am attaching the Screenshots & doing RTBC for the same.
- ๐ฉ๐ชGermany chr.fritsch ๐ฉ๐ช๐ช๐บ๐
chr.fritsch โ made their first commit to this issueโs fork.
- Status changed to Fixed
about 2 months ago 2:48pm 10 July 2024 -
chr.fritsch โ
committed 21fbe840 on 8.x-2.x authored by
atul_ghate โ
Issue #3020251: Fixed phpcs issues.
-
chr.fritsch โ
committed 21fbe840 on 8.x-2.x authored by
atul_ghate โ
Automatically closed - issue fixed for 2 weeks with no activity.