- π¦πΊAustralia VladimirAus Brisbane, Australia
Commit is looking good. Thanks for your contribution.
Couple of updates required- Description needs to be added to README
- Add dependency injection for new class
- Merge request !11Issue #3015366 by oknate: Easier way to inject ad in preprocess function or render array β (Open) created by apotek
- Status changed to Needs review
12 months ago 8:27am 9 January 2024 - πΊπΈUnited States apotek
Moved Nate's work into a git.drupalcode.org issue branch (with correct attribution) and added @VladimirAus's requested changes.
This is ready for review again.
- Status changed to RTBC
11 months ago 2:29am 13 January 2024 - πΊπΈUnited States apotek
Testing this, I ended up deep in the weeds of RenderCallback and TrustedRenderCallback interfaces before face-palming and remembering that all render functions are static, so @VladimirAus we can't use a DI pattern to inject entity_type.manager service into the class, but have to use \Drupal::service().
I pushed up latest changes, and this is tested.
- Status changed to Needs work
3 months ago 10:48am 24 September 2024 - π©πͺGermany Anybody Porta Westfalica
Changes should go into 2.0.x please. Needs retargeting.