Multiple warning messages when having untranslatable fields

From what I can tell the points in #21 have not been addressed/answered. Maybe @berdir answers #21.2

Tagging for usability review for the phrase.

I discussed this a bit with @laurii at DevDays23 and he pointed me to the fact that something very similar has been done in \Drupal\ckeditor5\Plugin\Editor\CKEditor5::buildConfigurationForm() if for slightly different reasons. But I think that would have similar problems as well with the message repeating on submit and ajax operations.

I still think it makes sense to solve this bug and then think about a generic solution or not using warning messages for this at all. We discussed that the new toggletip might give us some points.

I also cleaned up the patch and removed a lot of unrelated changes and I removed the $form_state check, that should indeed not be required anymore.

The last submitted patch, 43: multiple_warning_message_3002571-43.patch, failed testing. View results →

Cleaned up a the kernel test, the previous fix did work before, but only because it didn't actually test the display message part anymore. Now with the removed form state checks, the previous two cases also had the message form element, I fixed them and removed the logic for display warning completely.

No fond of those kind of tests, I don't think they're testing much and are hard to understand and maintain.

Removing the needs usability review tag. I don't think there's something to review here, that you no longer get duplicated messages or a message after saving the node doesn't needs a usability review. The issue that would need one is the follow-up that I created that wants to use a different pattern than warning messages for this.

Ok, we can actually clean up quite a bit more in that test as we no longer need those two flags at all.

meh.

Ran the tests without the fix and got

ContentTranslationUntranslatableFieldsTest

Behat\Mink\Exception\ResponseTextException : The text "Fields that apply to all languages are hidden to avoid conflicting changes." appears in the text of this page, but it should not.

ContentTranslationHandlerTest passes without issue.

The fix matches the IS of transforming message to array.

Think this is good!

Committed 29ae244 and pushed to 11.x. Thanks!

Not backporting to 10.1.x because of the small behavior change here.

I updated the code comment on commit. Here's interdiff for that.

Automatically closed - issue fixed for 2 weeks with no activity.

Patch updated for 10.2.x branch.