comment_node_update_index() indexes only first page of comments

Created on 5 September 2018, almost 6 years ago
Updated 30 January 2023, over 1 year ago

Problem/Motivation

Hook comment_node_update_index try to add content of comments of a node to search index. It does using CommentStorage::loadThread and passing number of comments per page for pager usage actually. This leads to the fact, that only the content of the first page of thread is added.

Proposed resolution

Do not pass number of comments to load thread. This will load all available comments.

Remaining tasks

Provide patch and test.

User interface changes

-

API changes

-

Data model changes

-

πŸ› Bug report
Status

Needs work

Version

10.1 ✨

Component
CommentΒ  β†’

Last updated 3 days ago

Created by

πŸ‡©πŸ‡ͺGermany a_grizzli

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • The Needs Review Queue Bot β†’ tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

    Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

    Consult the Drupal Contributor Guide β†’ to find step-by-step guides for working with issues.

Production build 0.69.0 2024