StatisticsPopularBlock breaks a page rendering when nid left orphan

Created on 24 July 2018, over 6 years ago

Updated 30 April 2024, 10 months ago

Problem/Motivation

I found an annoying bug in statistics module - it crashes the site page rendering if you somehow have nid for non-existing node in the node_counter table. I don't know how it happened and I could not make it happen at will, but reference to a deleted node has not been removed from the table. That causes use of NULL instead if the node object and the site page rendering breaks - on every page that has StatisticsPopularBlock. The fix is simple - just 2 lines to modify in the function StatisticsPopularBlock::nodeTitleList(). I can supply a patch for the fix, it is pretty obvious on lines 195 and 196 in StatisticsPopularBlock.php file.

Steps to reproduce

Proposed resolution

TBD

Remaining tasks

Update patch
Add a test
Review
Commit

User interface changes

TBD

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

🐛 Bug report

Status

Needs review

Version

1.0

Component

Statistics →

Last updated 18 days ago

No maintainer

Created by

🇺🇸United States calmforce

Live updates comments and jobs are added and updated live.

Bug Smash Initiative

Needs reroll
The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

Needs tests
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment about 2 years ago →
🇳🇿New Zealand quietone
Statistics is approved for removal. See 🌱 [Policy] Deprecate Statistics module in D10 and move to contrib in D11 Fixed

This is now Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project → and the Extensions approved for removal → policies.

It will be moved to a contributed Statistics project once the project is created and the Drupal 11 branch is open.
Status changed to Needs review 10 months ago12:44pm 30 April 2024
Comment 10 months ago →
🇳🇿New Zealand quietone

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024