There is an issue when using moderation_note with Display Suite DsFields.
> Error: Call to a member function getFieldDefinition() on array in moderation_note_preprocess_field() (line 147 of moderation_note/moderation_note.module).
Because Dsfields use the 'field' theme, the element structure is a little funky. moderation_note_preprocess_field expects $element['#items'] to exist, and to be an instance of \Drupal\Core\Field\FieldItemList. However DsField provides an array for this key:
ds/ds.module:389 (ds_entity_view_alter()):
'#items' => [(object) ['_attributes' => []]],
The only usage in moderation note for getFieldDefinition() is to eventually get the field type. However the preprocess $variables already provides a simpler and consistent way to get it.
The patch removes the use of $element['#items'] to get field type and uses the field type in $variables instead.
Closed: cannot reproduce
1.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
I am able to use moderation note with Display Suite.
I think this is no longer relevant. Can someone confirm they are not able to use Display Suite with moderation note?