- 🇺🇸United States luke.leber Pennsylvania
I think that this might be best fixed with setting the
#maxlength
property on the existingtextfield
type.Textareas come with the side-effect of allowing newline characters, which doesn't seem to be very helpful in this context. If this change can be re-rolled against 2.0.x, I'd be glad to re-review it and get the ball rolling.
Cheers.
- Issue was unassigned.
- 🇺🇸United States luke.leber Pennsylvania
Unassigned - it's been assigned for 5 years now :-D!
- Assigned to shivam_tiwari
- @shivam_tiwari opened merge request.
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 8:08am 9 May 2023 - last update
over 1 year ago 1 pass - last update
over 1 year ago Patch Failed to Apply - Status changed to Needs work
over 1 year ago 12:48pm 9 May 2023 - 🇺🇸United States luke.leber Pennsylvania
Citing https://www.sistrix.com/ask-sistrix/technical-seo/site-structure/url-len..., I think we'd want to use the closest PoT (Power of Two) length to the minimum supported URL length in the list. This happens to be Microsoft Edge with a max supported length of 2083 characters.
The closest PoT is 2048 characters, so I propose that the
#maxlength
be 2048. - 🇮🇳India chandreshgiri gauswami
Chandreshgiri Gauswami → made their first commit to this issue’s fork.
- last update
over 1 year ago 1 pass - @chandreshgiri-gauswami opened merge request.
- Assigned to shivam_tiwari
- Issue was unassigned.
- Status changed to Needs review
over 1 year ago 12:14pm 10 May 2023 - last update
over 1 year ago 1 pass -
Luke.Leber →
committed bb9b65a3 on 2.0.x authored by
Chandreshgiri Gauswami →
Issue #2971954 by shivam_tiwari, blacklabel_tom, woutgg, Chandreshgiri...
-
Luke.Leber →
committed bb9b65a3 on 2.0.x authored by
Chandreshgiri Gauswami →
- 🇺🇸United States luke.leber Pennsylvania
Merged !10 into 2.0.x to be included in a 2.0.1 patch release (timeline pending).
Thanks!
- Status changed to Fixed
over 1 year ago 2:43am 11 May 2023 Automatically closed - issue fixed for 2 weeks with no activity.