Does not work with core media

Open on Drupal.org →

Created on 25 April 2018, over 6 years ago

Updated 3 September 2024, 3 months ago

Please let me know if there is already an issue for this. It looks like AEL does not work with core media entities, at least not for the variant where the label is generated after saving the entity. The reason seems to be that the hook invoked when a media item is created is hook_entity_create(), while AEL implements hook_entity_presave(). Does this sound plausible at all?

🐛 Bug report

Status

Needs review

Version

3.0

Component

Code

Created by

🇳🇱Netherlands eelkeblok Netherlands 🇳🇱

Live updates comments and jobs are added and updated live.

Incomplete comments

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment almost 2 years ago →
🇺🇸United States SocialNicheGuru
No longer applies to 3.0 version
Comment 8 months ago →
🇺🇸United States kevinquillen
Re-rolled for 3.x. Worked for me in the following scenarios:

Single upload at Add Media

Bulk upload at Add Media

Single upload in Media Library browser

Bulk upload in Media Library browser
Comment 8 months ago →
🇺🇸United States kevinquillen
Attaching patch.
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.1 & MySQL 5.7
last update 8 months ago
19 pass, 2 fail
Status changed to Needs review 8 months ago4:36pm 18 March 2024
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 7.3 & MySQL 8
last update 8 months ago
Patch Failed to Apply
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 7.3 & MySQL 8
last update 8 months ago
Patch Failed to Apply
Comment 8 months ago →
🇺🇸United States kevinquillen
Comment 8 months ago →
🇺🇸United States kevinquillen
Anyone know what the test failures pertain to?
Comment 3 months ago →
lars.stiebenz
The patch is a re-roll of the one in #2965989-10: Does not work with core media → against auto_entitylabel 3.3.0.
It requires the core patch from #2965989-3: Does not work with core media → too: drupal-media-pre-preparesave-hook.patch →
The core patch invokes a hook and the auto_entitylabel patch implements it.

Since there is still an ongoing discussion in #2992426: Add entity methods and hooks for executing pre/post code outside of the save transaction → , the name of the hook might change or an event might be used instead of a hook.
Comment 3 months ago →
🇺🇸United States SocialNicheGuru
Drupal 10.3.2 the core patch in 3 does not work:

https://www.drupal.org/files/issues/2019-09-11/auto_entitylabel-core-med... → (Drupal 10 core patch - AEL Does not work with core media)
Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2019-09-11/auto_entitylabel-core-med... →

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024