Refactor/cleanup module code

Created on 18 April 2018, about 6 years ago

Updated 9 August 2023, 11 months ago

Thanks for this module, functionally it was doing exactly what we were looking for. Nice and lean.

It did need some clean up. I meant to do it in separate issues but it all started overlapping a bit too much, so in the end it's just one big one.
Feel free to cherry pick what you want to use.

Things I addressed:

Update the help hook to real info instead of copy/paste placeholder text
Update the query alter hook to just trigger on the 'search_node_search' tag instead of looking at other tags
Store excluded nids in state not config since these settings will be different on different environments (should this be done in a stable release this still needs an upgrade path to move the settings from config to state)
Get rid of some deprecated code and use more dependency injection in the form

📌 Task

Status

Needs work

Version

2.0

Component

Code

Created by

🇳🇱Netherlands Lendude Amsterdam

Live updates comments and jobs are added and updated live.

Needs reroll
The patch will have to be re-rolled with new suggestions/changes described in the comments in the issue.

Incomplete comments

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Comment 11 months ago →
🇩🇪Germany Anybody Porta Westfalica
CS issues have been fixed in the D10 upgrade task.
First commit to issue fork.
Open on Drupal.org →
Core: 10.0.7 + Environment: PHP 8.0 & MySQL 5.7
last update 10 months ago
Waiting for branch to pass
@rpayanm opened merge request.

contrib.social Blog FAQ Discussions

Production build 0.69.0 2024