- ๐จ๐ฆCanada Liam Morland Ontario, CA ๐จ๐ฆ
Is this really a beta blocker?
- Issue was unassigned.
- Status changed to Needs review
10 months ago 4:46pm 18 November 2023 - last update
10 months ago 32 pass, 3 fail - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Finally got around to working on this again. As said above, Iโm going forward with approach number 1 โ patch attached. Unfortunately, there is still a test fail which I canโt quite figure out, and which I also canโt reproduce testing manually, so thatโs a bit annoying, but I thought maybe someone still wants to review already, or maybe even has an idea how to fix the test.
I also implemented dorficusโ suggestion of putting the different search type form sections into vertical tabs, which really looks qute good. I was almost done with it when I realized it was completely out of scope here, so to not let that go to waste I still included it.
The last submitted patch, 15: 2955515-15--configurable_notification_interval.patch, failed testing. View results โ
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.- last update
9 months ago 48 pass - ๐ฆ๐นAustria drunken monkey Vienna, Austria
OK, I think I figured it out.
Would be great to get some feedback/tests/reviews on this and then we can finally have a Beta release. -
drunken monkey โ
committed a57960d7 on 8.x-1.x
Issue #2955515 by drunken monkey, dorficus: Added support for editing of...
-
drunken monkey โ
committed a57960d7 on 8.x-1.x
- Status changed to Fixed
9 months ago 4:13pm 27 December 2023 - ๐ฆ๐นAustria drunken monkey Vienna, Austria
Alright, would have been better with feedback, but Iโm just rolling with it now to finally get this resolved.
Merged. Thanks again, everyone! Automatically closed - issue fixed for 2 weeks with no activity.
I haven't looked into the code enough to figure out what might be going on and suggest a solution so I just wanted to report an issue/observation based on my use of the module.
Background:
I am currently using search_api_saved_searches version 8.x-1.0-rc1I have been using the 'Default' search type created from installation of the module over a year ago.
Observation:
The notification interval field used to be available on the 'Default' search type but no longer is. When I create a new search type, 'notification interval' is available as a form field.
Suggested solution (to take with a grain with salt):
Maybe an update hook is required to update configuration for already created search types.