Pretty paths do not work in combination with contextual filters.

Created on 11 March 2018, about 7 years ago
Updated 14 November 2023, over 1 year ago

When I use this module in conjunction with a contextual filter for a view, the view returns the "Not found" (or whatever fallback behaviour is when the contextual filter parameter isn't in the url). As this is core functionality, I think contextual filters should (somehow) be supported.

Do you have any idea how this could be implemented?

🐛 Bug report
Status

Closed: outdated

Version

1.0

Component

Miscellaneous

Created by

🇳🇱Netherlands marcus_w

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • 🇪🇸Spain facine

    When the view has an alias, I get a 404, it seems that the route for the alias does not exist.

    I'm not sure how to fix it, but for now, I've duplicated the path using the alias path.

  • 🇪🇸Spain facine

    I've update the latest patch fixing a small bug with the path lenght.

  • Open in Jenkins → Open on Drupal.org →
    Core: 10.0.11 + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Patch Failed to Apply
  • Open in Jenkins → Open on Drupal.org →
    Core: 9.5.x + Environment: PHP 8.1 & MySQL 8
    last update over 1 year ago
    Patch Failed to Apply
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.4 + Environment: PHP 8.2 & MySQL 8
    last update over 1 year ago
    Patch Failed to Apply
  • Open in Jenkins → Open on Drupal.org →
    Core: 10.1.x + Environment: PHP 8.2 & MySQL 8
    last update over 1 year ago
    Patch Failed to Apply
  • 🇨🇦Canada joseph.olstad

    @facine
    your patch isn't applying cleanly to the head of the 8.x-1.x branch

    Not sure what your code is supposed to be patching, there's no recent changes.

  • 🇨🇦Canada joseph.olstad
     ╭─◀ ☕ j portable-5700u ▶ ~/drupal.org/facets_pretty_paths ▶ 📂4  📃15 🔗0 ▶ 🔀 2.0.x ▶
     ╰❯ $ patch -p1 < facets_pretty_paths-2952005-9.patch 
    patching file facets_pretty_paths.services.yml
    patching file src/Plugin/facets/url_processor/FacetsPrettyPathsUrlProcessor.php
    Hunk #1 FAILED at 5.
    Hunk #2 succeeded at 33 (offset 2 lines).
    Hunk #3 FAILED at 65.
    Hunk #4 FAILED at 83.
    Hunk #5 FAILED at 169.
    4 out of 5 hunks FAILED -- saving rejects to file src/Plugin/facets/url_processor/FacetsPrettyPathsUrlProcessor.php.rej
    patching file src/RouteSubscriber.php
  • 🇨🇦Canada joseph.olstad

    Similar result with patch 9 vs 8.x-1.x

     ╭─◀ ☕ j envy-4700u ▶ ~/drupal.org/facets_pretty_paths ▶ 📂4  📃12 🔗0 ▶ 🔀 8.x-1.x ▶
     ╰❯ $ patch -p1 < facets_pretty_paths-2952005-9.patch 
    patching file facets_pretty_paths.services.yml
    patching file src/Plugin/facets/url_processor/FacetsPrettyPathsUrlProcessor.php
    Hunk #1 FAILED at 5.
    Hunk #2 succeeded at 33 (offset 2 lines).
    Hunk #3 FAILED at 65.
    Hunk #4 FAILED at 83.
    Hunk #5 FAILED at 169.
    4 out of 5 hunks FAILED -- saving rejects to file src/Plugin/facets/url_processor/FacetsPrettyPathsUrlProcessor.php.rej
    patching file src/RouteSubscriber.php
    

    Still 4 out of 5 hunks failing

  • Status changed to Closed: outdated over 1 year ago
  • 🇨🇦Canada joseph.olstad

    I suggest upgrading your facets_pretty_paths module to a more recent build before commenting on this issue.

Production build 0.71.5 2024