Improve rendering account link in the toolbar

Here's a new approach that doesn't require specifying heights.

The last submitted patch, 46: 2951268-46.patch, failed testing. View results →

Not sure where did #47 come from but looks like #46 passed 🤔

Verified the patch #47 and tested it on Drupal version 10.1.x. Now the vertical position of the account icon is not changing on page load and I have added the before and after screen recordings for reference.

✨ Interface previews/skeleton screens through optional "preview" or "placeholder" templates Fixed landed which means we could probably customize the placeholder for the account link.

Patch has the placeholder approach, and here's a video of it working on a throttled connections, so we can see that the icon remains in the correct location throughout the deliberately slow load process. https://youtu.be/JrU7Cvqr53c

Not able to verify the patch #53 as it is showing error while applying the patch:

Checking patch core/lib/Drupal/Core/Render/Renderer.php...
error: while searching for:
        '#cache',
        '#create_placeholder',
        '#lazy_builder_preview',
        // The keys below are not actually supported, but these are added
        // automatically by the Renderer. Adding them as though they are
        // supported allows us to avoid throwing an exception 100% of the time.

error: patch failed: core/lib/Drupal/Core/Render/Renderer.php:327
error: core/lib/Drupal/Core/Render/Renderer.php: patch does not apply
Checking patch core/modules/user/user.module...

@Nayana Ramakrishnan just above your comment in #54 is clear evidence the patch applies fine. Whenever a patch is uploaded, Drupal's testbot applies that patch to the specified branch and runs tests. If there's a green box stating "pass", that means the patch is applying to Drupal fine.

Since it's proven that the patch is applying fine to Drupal 10.1.x, the issue is specific to you and doesn't need a comment here. If you need help with troubleshooting issues with patches applying, Drupal Slack might be a good place to look as what you're dealing with is not specific to this issue. Ideally we avoid comments within an issue that are not specific to that issue (such as the one I just typed... 😐)

@bnjmnm Thank you for pointing out that. I guess there was some issue with my repo. I created a new repo and applied the patch. Patch #53 applied cleanly and tested it on Drupal version 10.1.x. Attaching the before and after screen recordings for reference.

Reviewed this.

+++ b/core/lib/Drupal/Core/Render/Renderer.php
@@ -327,6 +327,7 @@ protected function doRender(&$elements, $is_root_call = FALSE) {
+        '#preview',

This change was surprising to me at first, but after re-reading ✨ Interface previews/skeleton screens through optional "preview" or "placeholder" templates Fixed , it was a missed addition from that issue.

Due to the nature of this change (printing a space during rendering), and given the gaps in our testing infrastructure, this is not testable (other than manually).

Manual review shows that the vertical position is fixed!

Committed 905efbc and pushed to 10.1.x. Thanks!

Linked this as an example in the interface preview change record: https://www.drupal.org/node/3338948 →

Automatically closed - issue fixed for 2 weeks with no activity.