Facet summary block never empty

Created on 5 March 2018, over 6 years ago
Updated 3 May 2024, about 2 months ago

Problem/Motivation

The facet summary block is never truly empty, if there are no active filters then the block itself will still be outputted since the renderable array is always filled in the DefaultFacetsSummaryManager.
The issue arises in DefaultFacetsSummaryManager::build, where $build is set with the theme callback and '#items' is set with the results or an empty array.

Proposed resolution

Only initialise build with the theme data if there are actually results. All processors check for the existence of $build['#items'] already so they will remain working.

Remaining tasks

#2951763: Show count processor should always build when enabled. β†’

πŸ› Bug report
Status

Needs review

Version

2.0

Component

Facet summary

Created by

πŸ‡³πŸ‡±Netherlands Erik FrΓ¨rejean πŸ΄β€β˜ οΈ

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

Production build 0.69.0 2024