- Merge request !92Issue #2946829 by marcoscano, sokru, anybody: Make submit button on modal always visible β (Open) created by Anybody
- π©πͺGermany Anybody Porta Westfalica
This generally works nice, but besides the failing tests, now contents of the view are hidden, e.g. the pager. They are overlayed by the actions area and can't be reached.
thomas.frobieter β made their first commit to this issueβs fork.
- π©πͺGermany Anybody Porta Westfalica
anybody β changed the visibility of the branch 2946829-make-submit-button-always-visible to hidden.
Okay, the form actions are docked on the regular entity browser forms. Not the multistep forms, as this require additional work.
Thoughts on the multistep forms:
- The selected item list shouldn't be docked because the docked section can become very tall. If it should be docked, it needs to be collapsible (collapsed by default) maybe with a counter of the selected items, so that the user can see that the selection has succeeded. Alternative ideas: Display the selected items either above the item list or as a collapsible sidebar (in this case, the modal would need to be wider)
- The 'Use selected' and 'Hide selected' buttons should be located in the same form actions wrapper as the 'Select entities' button, so that we have one single docked bar.
- π©πͺGermany Anybody Porta Westfalica
Thank you @thomas.frobieter simple and effective and clear UX improvement!
RTBC+1 but I'll wait for other feedback as I also had my hands in...