Contrib.social

[PP-1] Settings Tray prevents editing some fields with QuickEdit module

Open on Drupal.org →
Created on 12 February 2018, almost 7 years ago
Updated 27 February 2023, over 1 year ago

Problem/Motivation

When both Settings Tray and Quick Edit module are enabled then you can edit certain inputs in QuickEdit.

Steps to reproduce:

  1. Enable both Settings Tray and Quick Modules
  2. Create an article
  3. View the article
  4. Enter Settings Tray "Edit" mode by clicking "Edit" in the toolbar
  5. Click the article body text to open QuickEdit toolbar.
  6. Click on author name to edit
  7. The "author" input textbox appear.
  8. Attempt to click in the text box (you can't!)

We need to fix the last step.

Proposed resolution

We need to fix the CSS pointer-events: none; that stops this.

Remaining tasks

Postponed on 📌 Fix race conditions in OffCanvasTestBase Needs work
Review patch

User interface changes

None, it will just work.

API changes

None

Data model changes

None

🐛 Bug report
Status

Postponed

Version

1.0

Component

Code

Created by

🇺🇸United States tedbow Ithaca, NY, USA

Live updates comments and jobs are added and updated live.
  • CSS

    It involves the content or handling of Cascading Style Sheets.

  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

  • Needs usability review

    Used to alert the usability topic maintainer(s) that an issue significantly affects (or has the potential to affect) the usability of Drupal, and their signoff is needed. When adding this tag, make it easy to review the issue. Make sure the issue summary describes the problem and the proposed solution. Screenshots usually help a lot! To get sign-off on issues with the "Needs usability review" tag, post about them in the #ux channel on Drupal Slack, and/or attend a UX meeting to demo the patch and get direct feedback from designers/UX folks/product management on next steps. If an issue represents a significant new feature, UI change, or change to the general "user experience" of Drupal, use Needs product manager review instead. See the scope of responsibilities for product managers.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment over 1 year ago →
    🇳🇿New Zealand quietone

    This issue was discussed in #bugsmash bu dww, lendude, mstrelan and myself. I noticed this issue because 'Quick Edit' is in the title and that has been removed. I was wondering if this should move to the contrib project. Looking at the patch, lendude pointed out that the fix was in settings tray, so we should leave this issue here. On the other hand, mstrlen pointed out that the patch fixes the problem by adding a selector targeting .quickedit-editing so it could move to contrib. For that reason, I am moving this to the contrib project.

    I updated the IS to add the issue this is postponed on.

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024