Condition based on order subtotal instead of order total

#11 works on my end too

The patch in #11 works for me as well.

But I have one remaining issue. When using this for a promotion that gives a discount on the shipping fee, the promotion is only applied after saving the order. Hence when continuing in the checkout flow to the next step. This is a problem when using AJAX to recalculate shipping costs. The order totals fetched via AJAX don't apply the promotion correctly, but after clicking the "Continue" button, the promition is applied correctly.

After reviewing this with jsacksick today in the context of a client using the patch in #7. I actually can't remember why I thought it would be better for us to have a separate condition as zaporylie implemented for us in #11. The issue I have with it in hindsight is that it's now ambiguous - which one should I be using? Is the regular "Order total" condition somehow not a current order total?

Additionally, I think I may have introduced some scope creep in responding to bojanz re: how to accommodate different adjustment types. Sufficient for the day is its own trouble ... we could have just landed a patch that differentiated between the current order total vs. order item subtotal a while back and figured out how to further subdivide in a follow-up issue.

I propose we go back to jsacksick's patch for now with some slight adjustment to the labels:

Total to compare against

1. Order total
2. Sum of order item totals

The point of the description is to try to make it clear what "current" means ... the problem is these conditions are used in multiple contexts, and "current" isn't terribly descriptive. Then we can create a follow-up issue to add a third option that would let us get to some sort of price + adjustments selection widget.

Added slight adjustment for label and tests

Fix for failed tests

One thing that was forgotten including in the patch from #7 is the schema update (commerce_order.schema.yml) we need to add the new setting there.

Committed, thanks!

Automatically closed - issue fixed for 2 weeks with no activity.