Switch to hook_user_presave() for setting username

I think this needs further maintainer feedback to decide, how to proceed here? Or from someone very very experienced in Drupal development? Any active maintainers?

Or could someone raise this in slack perhaps for help?

Created MR!10 from #20 by @JeremySkinner - please note for credits.

So we can proceed and review here more easily.

@Grevil could you please have a look, now, as you're deep into this area?
So we can probably finish this! What do you think? We might create a 2.x branch for switching to semver and have this possibly dangerous change separated for now?

We might create a 2.x branch for switching to semver and have this possibly dangerous change separated for now?

The current MR's changes are the NON-dangerous compatibility changes. We might as well merge them as a current workaround and create a follow-up issue / leave this issue open.

Although I agree with @krystalcode here. The hook implementations wasn't properly implemented in the first place. And I do not see a case, where we do not have the $account variable in presave?

So I'd say we should rather orientate our code on patch #18 by @krystalcode rather than #20. And adjust our submodule logic accordingly.

#20 would be no danger, while I'd say we should be careful with #18 as it changes functionality and in contrast to the current implementation means, the username will change, when the user is being resaved! That might be unexpected for existing sites.

I'm fine with a MR here and I'm fine to plan this for a 2.x release, as it's kind of breaking change. But we shouldn't rush here?

PS: Implementing #18 will take things closer to the logic of the new submodule. I think the logic from there (when to change an existing username) is good and should be uplifted then @Grevil?

Would you like to prepare a MR from all of that, once the other issues are fixed?
Targeting 2.x then (in the MR name?)

Yea, let's do that!

the username will change, when the user is being resaved!

Yea, we need to circumvent that, similar to how we did it in the submodule.

Gave credit in 🌱 [2.x] Rework username generation save logic Active .

Done through 🌱 [2.x] Rework username generation save logic Active

Automatically closed - issue fixed for 2 weeks with no activity.