- First commit to issue fork.
- 🇺🇸United States loze Los Angeles
Went through the 2 patches and created a MR to work from. it appears to be solving the issue in my initial testing.
- 🇺🇸United States loze Los Angeles
To summarize what this does:
1. Splits up all the barrating styles css files into their own libraries and only loads them if they are set on the widget
2. Provides a global config page where the admin can choose to disable fontawesome or glyphicons from being included in cases when they are already including them in your theme. - 🇺🇸United States tr Cascadia
Provides a global config page where the admin can choose to disable fontawesome and glyphicons from being included for cases where you are already including them in your theme (or don't want them at all).
Is this part really needed? If these are assets we need for votingapi_widgets, then we need to load them - there should be no choice. Likewise, I think the whole point of using libraries like this is that Drupal core takes care of removing the duplicates - you shouldn't have to be aware of what the theme or some other module is loading.
- 🇺🇸United States loze Los Angeles
We could probably get away with not adding it. It was in the it the original patches to I added it to the MR.
I know in my case, I am using a limited version of Font Awesome from their CDN that only includes a subset of the icons that I need, stars are included in this. So I don't need this module to include them. I could always remove the library in a hook, but an option here seemed convenient.
The same could be true for glyphicons.