ExposedFormCache invalid logic

Created on 3 October 2017, over 6 years ago
Updated 17 August 2023, 10 months ago

Problem/Motivation

There is a flaw in ExposedFormCache class. The setForm() method is setting a local $views_exposed variable instead of using the $this->cache property which is used throughout this class

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

πŸ› Bug report
Status

Needs work

Version

9.5

Component
ViewsΒ  β†’

Last updated about 4 hours ago

Created by

πŸ‡ͺπŸ‡ͺEstonia Martin.

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • πŸ‡ΊπŸ‡ΈUnited States angrytoast Princeton, NJ

    The premise here seems odd. ExposedFormCache is treating the exposed form data as if it was a request level static cache. In the current state, this would only be beneficial if the view display was rendered more than once on a page?

    Should this cache data be in a persistent cache bin instead?

Production build 0.69.0 2024