Add search and reset feature to taxonomy admin form

Created on 5 September 2017, over 7 years ago
Updated 1 March 2023, about 2 years ago
โœจ Feature request
Status

Needs review

Version

2.0

Component

Code

Created by

๐Ÿ‡ฎ๐Ÿ‡ณIndia sudishth

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan Odai Atieh Amman

    Rerolled the patch

  • Status changed to Needs work about 2 years ago
  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia

    Thanks for contributions. ๐Ÿฅ‚
    Switching to MRs, please commit to gitlab.

    phpcs returns

    
    FILE: /Users/tesboss/_PROJECTS/drupal/taxonomy_manager/src/Form/MoveTermsForm.php
    -------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    -------------------------------------------------------------------------------------------------------------------------------------
     63 | ERROR | The array declaration extends to column 90 (the limit is 80). The array content should be split up over multiple lines
    -------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/tesboss/_PROJECTS/drupal/taxonomy_manager/src/Form/ExportTermsMiniForm.php
    ---------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
    ---------------------------------------------------------------------------------------
     60 | WARNING | Unused variable $desccsv.
     78 | WARNING | Possible useless method overriding detected
    ---------------------------------------------------------------------------------------
    
    
    FILE: /Users/tesboss/_PROJECTS/drupal/taxonomy_manager/src/Form/ExportTermsForm.php
    ----------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AND 4 WARNINGS AFFECTING 7 LINES
    ----------------------------------------------------------------------------------------------
      94 | WARNING | Line exceeds 80 characters; contains 98 characters
     121 | ERROR   | Comment indentation error, expected only 1 spaces
     122 | ERROR   | Comment indentation error, expected only 8 spaces
     133 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     141 | WARNING | Possible useless method overriding detected
     170 | ERROR   | Comment indentation error, expected only 1 spaces
     182 | WARNING | Line exceeds 80 characters; contains 86 characters
    ----------------------------------------------------------------------------------------------
    
    
    FILE: /Users/tesboss/_PROJECTS/drupal/taxonomy_manager/src/Form/TaxonomyManagerForm.php
    ------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 3 ERRORS AND 5 WARNINGS AFFECTING 7 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------
      77 | ERROR   | Parameter $entity_form_builder is not described in comment
     222 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     227 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     265 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     265 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     268 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
     317 | ERROR   | Public method name "TaxonomyManagerForm::taxonomy_term_submit_handler" is not in lowerCamel format
     459 | ERROR   | Doc comment is empty
    ------------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/tesboss/_PROJECTS/drupal/taxonomy_manager/src/TaxonomyManagerHelper.php
    ----------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
    ----------------------------------------------------------------------------------------------------------------------------------------
     155 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
     259 | ERROR   | The array declaration extends to column 97 (the limit is 80). The array content should be split up over multiple lines
    ----------------------------------------------------------------------------------------------------------------------------------------
    
    Time: 827ms; Memory: 12MB
    
    
    
  • @vladimiraus opened merge request.
  • Status changed to Needs review about 2 years ago
  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia
  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan Qusai Taha Amman

    Rerolled the patch

  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan Qusai Taha Amman

    Rerolled the patch

  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan Qusai Taha Amman
  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan Qusai Taha Amman

    Re-roll patch

  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan Qusai Taha Amman

    Re-roll patch

  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan oways23

    Re-roll patch 52

  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia

    vladimiraus โ†’ changed the visibility of the branch 2906768-add-search-and to hidden.

  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia

    vladimiraus โ†’ changed the visibility of the branch 2906768-add-search-and to hidden.

  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia

    vladimiraus โ†’ changed the visibility of the branch 2906768-add-search-and to active.

  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia

    vladimiraus โ†’ changed the visibility of the branch 2906768-add-search-and to hidden.

  • Merge request !62Resolve #2906768 "Add search" โ†’ (Open) created by VladimirAus
  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia

    Neither #52 or #54 is applicable to the dev branch.
    Please use new MR from now on for better review.

  • ๐Ÿ‡ฆ๐Ÿ‡บAustralia VladimirAus Brisbane, Australia
  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan ahmad abbad Jordan

    ahmad abbad โ†’ made their first commit to this issueโ€™s fork.

  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan ahmad abbad Jordan

    ahmad abbad โ†’ changed the visibility of the branch 2906768-add-search-option to hidden.

  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan ahmad abbad Jordan

    ahmad abbad โ†’ changed the visibility of the branch 2906768-add-search-option to active.

  • ๐Ÿ‡ฏ๐Ÿ‡ดJordan ahmad abbad Jordan

    A new MR was created

Production build 0.71.5 2024