- First commit to issue fork.
- @hosterholz opened merge request.
- Status changed to Needs review
over 1 year ago 10:28am 13 March 2023 - 🇩🇪Germany Anybody Porta Westfalica
@a.dmitriiev is this still an issue in 4.x? Then we should switch the version.
When the user is authenticated and in the blacklist of urls there is path like /admin/* , user will get redirect loop because there is no check for authentication when trying to redirect to login page.
As it is said in the settings form for "Access denied action" Redirect to the login page: "Action to be performed when access is permitted by role, but the user is not logged in." it is needed to check if the user is logged in before redirecting to login page in Event Subscriber.
- review the patch
- no changes
- I propose to add getCurrentUser method to RestrictIpService to avoid injecting current_user service into EventSubscriber, because it is already injected into restrictip service.
- no changes
Needs review
3.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
@a.dmitriiev is this still an issue in 4.x? Then we should switch the version.