- @mondrake opened merge request.
- Status changed to Needs review
over 1 year ago 6:48pm 7 March 2023 - 🇮🇹Italy mondrake 🇮🇹
Rebased after 📌 Introduce TestRun objects and refactor TestDatabase to be testable Fixed and changed to MR workflow.
- 🇮🇹Italy mondrake 🇮🇹
@longwave and I discussed on Slack on whether working this issue would still making sense given to upcoming move to GitLab testing. We leaned to a no, but would like to get more feedback.
For sure it improves the console log output by showing execution time, passes, skips, incomplete etc., see latest MR test log https://dispatcher.drupalci.org/job/drupal_patches/171125/consoleFull
- 🇺🇸United States smustgrave
Would also say no but depends when exactly that switch will happen?
- Status changed to Closed: won't fix
over 1 year ago 9:42pm 10 March 2023 - Status changed to Needs work
about 2 months ago 11:56am 1 August 2024 - 🇬🇧United Kingdom catch
We're relying on run-tests.sh in gitlab CI, and didn't get very far trying to switch to paratest, so this is still relevant.
- 🇬🇧United Kingdom alexpott 🇪🇺🌍
@catch but now we have the reports in gitlab CI we are finally seeing which tests are skipped. You can see this in the gitlab reports. Unfortunately it does not tell you why but it is more information.
- 🇮🇹Italy mondrake 🇮🇹
Opened a new branch, just tried to merge the old MR with 11.x. Will fail badly...
- 🇬🇧United Kingdom catch
@alexpott right but we still print the run-tests.sh output in the job logs, and it'd be better if it matched the test reports in gitlab. I always end up going to the jobs about 95% of the time to see what failed.
- 🇮🇹Italy mondrake 🇮🇹
In PHPUnit 10+ the Junit log does not separate between skipped and incomplete tests, both are reported as ‘skipped’. Also, there is no specific logic around risky tests.
We can simplify here accordingly.
- Status changed to Needs review
about 2 months ago 6:57pm 3 August 2024 - 🇮🇹Italy mondrake 🇮🇹
This is an issue where the review makes more sense when tests fail :)
What's being output currently by run-tests.sh in the 'Detailed test results' section is very simpletest-ish, and possibly needs reconsideration.
1) the 'Group' column in PHPUnit always bears 'Other', so it's useless. I replaced it with the execution time of the single test case.
2) the 'Function' column in PHPUnit is the name of the test, including the name of the dataset provided by a data provider. I renamed the column to 'test'.
3) all reported lines are adding an empty line - it's meant to bear a message, but in PHPUnit passed and skipped test cases never have one. So just skipped here to print anything if the message is missing.Also, in HEAD right now if a PHPUnit test run ends with a 'error' exit code, we have a duplicate line reported for the same test class. Fixed here.
Also fixed that if the PHPUnit runner fails for failure/errors, we miss details of testcases passed/failed/errored.Reviews, based on the output of the MR, appreciated.
- 🇮🇹Italy mondrake 🇮🇹
Rebased after commit of 📌 Show test run time by class in run-tests.sh output Fixed .