Use rawurldecode() in LinkFormatter to correctly display encoded URLs

Created on 26 August 2017, about 8 years ago
Updated 26 October 2023, almost 2 years ago

Problem/Motivation

See #2869055: Decode URLs in "Redirect URL" view , a URL like /会社概要/イベン is displayed as an URL encoded string.

(From is the fixed redirect formatter, To is the core link formatter)

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Needs work

Version

11.0 🔥

Component
Link 

Last updated 7 days ago

Created by

🇨🇭Switzerland berdir Switzerland

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Merge Requests

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • First commit to issue fork.
  • last update almost 2 years ago
    30,430 pass, 4 fail
  • Status changed to Needs review almost 2 years ago
  • 🇮🇳India bhanu951

    Rerolled patch from #18 to 11.x Branch and created MR #5136

  • Pipeline finished with Failed
    almost 2 years ago
    Total: 584s
    #39015
  • Status changed to Needs work almost 2 years ago
  • 🇺🇸United States smustgrave

    Seems to have test failures from before.

  • First commit to issue fork.
  • 🇺🇸United States dcam

    dcam changed the visibility of the branch 11.x to hidden.

  • Pipeline finished with Failed
    12 days ago
    Total: 923s
    #587324
  • Pipeline finished with Success
    11 days ago
    Total: 791s
    #587423
  • 🇮🇳India bhanu951

    Failed test :

    
    Failure       1.416s *** Process execution output ***                                                
        PHPUnit 11.5.34 by Sebastian Bergmann and contributors.
        
        Runtime:       PHP 8.5.0beta2
        Configuration: /builds/issue/drupal-2904853/core/phpunit.xml.dist
        
        .D.......                                                           9 / 9 (100%)
        
        Time: 00:00.793, Memory: 10.00 MB
        
        Flatten (Drupal\Tests\migrate\Unit\process\Flatten)
         ✔ Flatten with array
         ⚠ Flatten with object
         ✔ Flatten invalid with empty·string
         ✔ Flatten invalid with string
         ✔ Flatten invalid with integer
         ✔ Flatten invalid with float
         ✔ Flatten invalid with NULL
         ✔ Flatten invalid with boolean
         ✔ Flatten invalid with xml
        
        1 test triggered 1 PHP deprecation:
        
        1) /builds/issue/drupal-2904853/core/modules/migrate/src/Plugin/migrate/process/Flatten.php:57
        ArrayIterator::__construct(): Using an object as a backing array for ArrayIterator is deprecated, as it allows violating class constraints and invariants
        
        Triggered by:
        
        * Drupal\Tests\migrate\Unit\process\FlattenTest::testFlatten#object
          /builds/issue/drupal-2904853/core/modules/migrate/tests/src/Unit/process/FlattenTest.php:30
        
        OK, but there were issues!
        Tests: 9, Assertions: 16, Deprecations: 1.
    ---- Drupal\Tests\migrate\Unit\process\SubstrTest ----
    
Production build 0.71.5 2024