Cancel rating icon is not working

latest patch doesn't apply.

rerolled patch.

Re-rolled

Test added

Here's a patch with just the test from #17. This should fail, to confirm the problem and to confirm that the test is actually triggering the problem and verifying the fix.

The last submitted patch, 18: 2899838-17-test-only.patch, failed testing. View results →

Good. That was as expected.

In this hunk:

     }

     // Add new vote.
-    $vote_manager->addVote($entity, $vote_rating, $field_settings['vote_type'], $owner->id());
+    if ($vote_rating !== 'cancel') {
+      $vote_manager->addVote($entity, $vote_rating, $field_settings['vote_type'], $owner->id());
+    }

     // Check to see if there is a target entity. If so, add the vote to that
     // entity as well.

Shouldn't the if ($vote_rating !== 'cancel') conditional also encompass the next code "Check to see if there is a target entity"? If we're canceling, we can skip that block as well.

re #20:
Fixed first point.
Second point can't be changed because cancel actually passes along an empty value back and hasValue considers it to exist. getValue is actually the right thing. I tried playing around with it and tests failed when I changed to hasValue. Yeah tests.

#21 looks good. However for the test, rather than just tack the asserts onto an existing test, I think it'd make more sense to split it off into it's own test method? Also, the cancel button should work without JS right, so does this need to be an Ajax/WebDriverTestBase test (i.e. could it be in Functional\FivestarTest instead?

Would also be nice to see this go green once the expanded test coverage over in 📌 Improve test coverage and add back "Allow voting" display option Needs review lands.