Coding Standard Issue

Created on 30 May 2017, over 7 years ago
Updated 21 August 2024, 4 months ago

There are some coding standard issues.

šŸ› Bug report
Status

Needs work

Version

1.0

Component

Code

Created by

šŸ‡®šŸ‡³India Ravi Sharma

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Issue was unassigned.
  • Status changed to Needs review almost 2 years ago
  • Status changed to Needs work 4 months ago
  • šŸ‡µšŸ‡­Philippines cleavinjosh

    Hi @rohit.rawat619,

    I applied patch #4, it was applied smoothly and fixed most of the phpcs issues.

    There are the remaining issues after I ran phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml:

    āžœ  imagefit git:(7.x-1.x) curl https://www.drupal.org/files/issues/2023-01-27/changes_imagefit.module-2882397-4.patch | patch -p1
      % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                     Dload  Upload   Total   Spent    Left  Speed
    100  4942  100  4942    0     0  10350      0 --:--:-- --:--:-- --:--:-- 10360
    patching file imagefit.info
    patching file imagefit.module
    āžœ  imagefit git:(7.x-1.x) āœ— ..
    āžœ  contrib phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig imagefit
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/imagefit/imagefit.info
    -----------------------------------------------------------------------------------------------------------
    FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
    -----------------------------------------------------------------------------------------------------------
     1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
    -----------------------------------------------------------------------------------------------------------
    
    
    FILE: /Users/interns/Demo-site/drupal-org-issues/web/modules/contrib/imagefit/imagefit.module
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    FOUND 5 ERRORS AND 4 WARNINGS AFFECTING 8 LINES
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
      8 | WARNING | Line exceeds 80 characters; contains 87 characters
      8 | WARNING | There must be no blank line following an inline comment
     12 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
     30 | ERROR   | Wrong function doc comment end; expected "*/", found "***********************************************************************************************/"
     60 | ERROR   | Doc comment is empty
     66 | ERROR   | Doc comment is empty
     70 | WARNING | Messages are user facing text and must run through t() for translation
     78 | ERROR   | Doc comment short description must be on a single line, further text should be a separate paragraph
     81 | WARNING | Do not use drupal_add_js() in hook_page_build(), use #attached for CSS and JS on the $page render array instead
    ------------------------------------------------------------------------------------------------------------------------------------------------------------------------
    
    Time: 176ms; Memory: 10MB
    
    āžœ  contrib

    Thank you.

Production build 0.71.5 2024