Contrib.social

Decode HTML entities in tag output, e.g. &309; becomes an apostrophe

Open on Drupal.org →
Created on 29 April 2017, about 7 years ago
Updated 6 February 2024, 5 months ago

Problem/Motivation

Even using the latest 8.x-dev version, I still have apostrophe encoding issues in my metatag. I can fine multiple issues about in the issue queue, all are flagged 'fixed' suggesting it works. For instance:
#2649592: Write tests to cover apostrophe handling in meta tags →

Yet if I enter "alex's" in any metatag it gets outputted like:

<meta name="title" content="alex&#039;s title" />
<meta name="description" content="alex&#039;s description" />
<meta name="abstract" content="alex&#039;s" />
<meta name="keywords" content="alex&#039;s" />

I would expect view source to show:

<meta name="title" content="alex's" />
<meta name="description" content="alex's" />
<meta name="abstract" content="alex's" />
<meta name="keywords" content="alex's" />

Proposed resolution

Change the output so that HTML entities are not encoded.

Remaining tasks

  • Change the existing tests to check for plain strings in the output instead of encoded HTML entities.
  • Ensure that the quotation marks are not broken, i.e. don't introduce any XSS bugs.
  • Adjust the module's output accordingly.
✨ Feature request
Status

Active

Version

1.0

Component

Code

Created by

🇫🇷France Dom.

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

Not all content is available!

It's likely this issue predates Contrib.social: some issue and comment data are missing.

  • Comment about 1 year ago →
    🇺🇸United States Rick Hood

    I am having this issue.
    Drupal 9.5.7
    Metatag 8.x-1.22

    Actual site name: St. Paul's School

    Examples of output:

    St. Paul 's School

  • Status changed to Active about 1 year ago
  • Comment about 1 year ago →
    🇺🇸United States DamienMcKenna NH, USA

    Rick: Thanks for the info. Is there a difference in the output depending upon whether the string comes via a token or is manually entered in the per-entity field?

  • Comment 11 months ago →
    desie314

    No difference for me. An apostrophe from a token and from manual both output as &#039;

  • Comment 5 months ago →
    Darsana Prasad

    I am having this issue.
    Drupal 10.2.2
    PHP 8.2.14
    Metatag 2.0.0

    Example of output:
    <meta name="keywords" content="Women&#039;s entrepreneurship" />

contrib.social Blog FAQ Discussions
Production build 0.69.0 2024