- 🇬🇧United Kingdom catch
Small fix with plenty of new test coverage. Looks good.
- Status changed to Fixed
over 1 year ago 9:30am 17 March 2023 Automatically closed - issue fixed for 2 weeks with no activity.
System module hijacks the admin/reports/status page to group the output from its hook_requirements implementation into "General System Information". This gives admins a heads-up way to view system-level data about their Drupal install.
Unfortunately, this breaks the other heads-up information display about errors and warnings.
If system_requirements generates an error or warning, the feedback doesn't get grouped where we expect to find it with other non-system errors and warnings. This can lead to significant confusion:
- the "details" section doesn't contain the same number of values listed in the heads-up info.
- the errors and warnings generated by system_requirements are not visually denoted in any way to distinguish them from OK operation.
- if system_requirements is the only module generating warnings or errors, the "details" link doesn't work. There is no #error or #warning element on the page, because system.module hijacks them in the theme layer.
Here's an example demonstrating these issues for the "1 error" scenario:
Option 1: if system_requirements returns non-OK requirements, do not group them in the heads-up "General" display
Option 2: if system_requirements returns non-OK requirements, show them twice -- once in the "General" display, and once along with the errors and warnings listings, as applicable.
Here's a screenshot of proposed resolution, option 2, as implemented by patch in #2:
Fixed
10.1 ✨
Makes Drupal easier to use. Preferred over UX, D7UX, etc.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Small fix with plenty of new test coverage. Looks good.
Automatically closed - issue fixed for 2 weeks with no activity.