- last update
11 months ago Composer error. Unable to continue. - last update
11 months ago 19 pass, 4 fail - last update
10 months ago 24 pass, 2 fail - Status changed to Needs work
10 months ago 3:27pm 31 August 2023 - Status changed to Needs review
10 months ago 4:34pm 1 September 2023 - 🇺🇸United States wells Seattle, WA
@VladimirAus -- tests are failing on the base branch, not this patch.
Drupal\Tests\dfp\Functional\GlobalSettingsTest::testGlobalSettings
Exception: Drupal\Tests\BrowserTestBase::$defaultTheme is required. See https://www.drupal.org/node/3083055 → , which includes recommendations on which theme to use. - last update
10 months ago 24 pass, 2 fail - 🇺🇸United States wells Seattle, WA
Oops the last patch was just run against the wrong branch... trying 9.x again now.
- 🇺🇸United States wells Seattle, WA
And that is indeed the issue. Thought it was just a 10.x thing hah.
I have opened 🐛 $defaultTheme missing for tests Fixed to address the tests issues. Once that is merged tests here should pass again.
- last update
10 months ago Patch Failed to Apply - last update
10 months ago Patch Failed to Apply - 🇦🇺Australia VladimirAus Brisbane, Australia
What is your change @sja112?
Can you either create MR or interdiff so it is easy to review? - Status changed to Postponed: needs info
10 months ago 1:53am 15 September 2023 - 🇦🇺Australia VladimirAus Brisbane, Australia
Adding tests. Waiting for MR.
@wells: thank you. Your commit was merged. 🐛 $defaultTheme missing for tests Fixed