- 🇨🇦Canada Liam Morland Ontario, CA 🇨🇦
Re-roll of #6 for 8.x-4.x.
This doesn't fix the problem for me but perhaps this will be helpful to others.
- last update
about 1 year ago 88 pass
When you override node/taxonomy pages by page manager and add page variants the local tasks will disappear.
Caused by this check in \Drupal\Core\Menu\LocalTaskManager on line 220:
if ($route_name == $task_info['route_name']) {
if (!empty($task_info['base_route'])) {
$base_routes[$task_info['base_route']] = $task_info['base_route'];
}
// Tabs that link to the current route are viable parents
// and their parent and children should be visible also.
// @todo - this only works for 2 levels of tabs.
// instead need to iterate up.
and this \Drupal\page_manager\Routing\PageManagerRoutes
$route = new Route(
$path,
[
'_entity_view' => 'page_manager_page_variant',
'_title' => $variant->getTitle(),
'page_manager_page_variant' => $variant_id,
'page_manager_page' => $page_id,
'page_manager_page_variant_weight' => $variant->getWeight(),
// When adding multiple variants, the variant ID is added to the
// route name. In order to convey the base route name for this set
// of variants, add it as a parameter.
'base_route_name' => $route_name,
],
$requirements,
[
'parameters' => $parameters,
'_admin_route' => $entity->usesAdminTheme(),
]
);
$collection->add($first ? $route_name : $route_name . '_' . $variant_id, $route);
So LocalTaskManager can`t find local tasks for overrided node page variant
Use 2 hooks: hook_menu_local_tasks_alter(), hook_local_tasks_alter().
/**
* Implements hook_local_tasks_alter().
* Add canonical tasks for page variants
*/
function MYMODULE_local_tasks_alter(&$local_tasks) {
/* @var $entityStorage \Drupal\page_manager\Entity\Page */
$entityStorage = Drupal::entityTypeManager()->getStorage('page');
foreach ($entityStorage->loadMultiple() as $entity) {
/** @var \Drupal\page_manager\PageInterface $entity */
// If the page is disabled skip making a route for it.
if (!$entity->status() || !$entity->getVariants()) {
continue;
}
$entityType = FALSE;
foreach ($entity->getParameters() as $param) { // Get an entity type name
if (strpos($param['type'], 'entity:') === 0) {
$entityType = substr($param['type'], 7);
break;
}
}
if ($entityType) {
$entityTasks = [];
$entityTaskStr = 'entity.' . $entityType . '.canonical';
// Find all canonical tasks
foreach ($local_tasks as $task) {
if (strpos($task['route_name'], $entityTaskStr) === 0) {
$entityTasks[] = $task;
}
}
$first = TRUE;
/* @var \Drupal\Core\Routing\RouteProviderInterface $route_provider */
$route_provider = \Drupal::service('router.route_provider');
foreach ($entity->getVariants() as $variantId => $variant) {
/* @see \Drupal\page_manager\Routing\PageManagerRoutes::alterRoutes() */
// This check prevent route not found exception
if (!$first) {
foreach ($entityTasks as $task) {
$routeName = $task['route_name'] . '_' . $variantId;
$task['route_name'] = $routeName;
$local_tasks[$task['route_name']] = $task;
}
}
$first = FALSE;
}
}
}
}
/**
* Implements hook_menu_local_tasks_alter().
* Remove duplicates of canonical tasks for page variants
*/
function MYMODULE_menu_local_tasks_alter(&$data, $route_name) {
/* @var $entityStorage \Drupal\page_manager\Entity\Page */
$entityStorage = Drupal::entityTypeManager()->getStorage('page');
foreach ($entityStorage->loadMultiple() as $entity) {
/** @var \Drupal\page_manager\PageInterface $entity */
// If the page is disabled skip making a route for it.
if (!$entity->status() || !$entity->getVariants()) {
continue;
}
$entityType = FALSE;
foreach ($entity->getParameters() as $param) {
if (strpos($param['type'], 'entity:') === 0) {
$entityType = substr($param['type'], 7);
break;
}
}
if ($entityType) {
$entityTaskStr = 'entity.' . $entityType . '.canonical_';
$newTabs = [];
foreach ($data['tabs'][0] as $key => $tab) {
if (strpos($key, $entityTaskStr) === FALSE) {
$newTabs[$key] = $tab;
}
}
$data['tabs'][0] = $newTabs;
}
}
}
Needs review
4.0
User interface
It affects the ability of people with disabilities or special needs (such as blindness or color-blindness) to use Drupal.
Very small and simple change. Preferred over Quickfix.
The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
Re-roll of #6 for 8.x-4.x.
This doesn't fix the problem for me but perhaps this will be helpful to others.