- Status changed to Closed: works as designed
9 months ago 2:28pm 13 October 2023 - 🇩🇪Germany Grevil
We are now using hook_ENTITY_TYPE_presave, which doesn't require further verification.
Follow-up from #657472: Add setting to allow users to login with email address or username → .
The fix added in #2777701: Email registration module needs to do Profile validation prior to saving → was removed by accident and this didn't cause any failures.
@pfrenssen:
OK I didn't realize this. It appears a bug was fixed in that issue but there was no test added for it, and no documentation on why this is needed.
Any fix that is not tested can regress at any point in the future.
Add a test to make this future proof.
Closed: works as designed
2.0
Code
Not all content is available!
It's likely this issue predates Contrib.social: some issue and comment data are missing.
We are now using hook_ENTITY_TYPE_presave, which doesn't require further verification.